refactor: move IntegerField to pydantic #1759
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
TODO: if the global idea is ok, move each class from |
pierrecamilleri
approved these changes
Dec 8, 2025
Collaborator
pierrecamilleri
left a comment
pierrecamilleri
left a comment
There was a problem hiding this comment.
(apart from 5 console ones not related to modifications)
Were they already failing before ? Even on master branch ?
(normaly CI was passing not so long ago, however I have not investigated CI breaking in #1758 yet)
|
|
||
| # Process the cell (remove non-digit characters if bare_number is False) | ||
| if not self.bare_number: | ||
| pattern = re.compile(r"((^[^-\d]*)|(\D*$))") |
Collaborator
There was a problem hiding this comment.
Read value will be used once for each row, for performance reasons it would be useful to compile the regex outside of the function.
| ## Field._descriptor properties | ||
| descr = {**descr, **super().to_descriptor(validate=validate)} | ||
| ## Merge descriptor_descr into base_descr to preserve base order | ||
| descr = {**base_descr, **descriptor_descr} |
Collaborator
There was a problem hiding this comment.
If changing the order, the above comment needs to be updated ("_descriptor" has priority)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated pydantic logic to IntegerField.
All tests pass (apart from 5 console ones not related to modifications)
Fixed a few issued: